Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mask-image property added and code refactor #1396

Merged
merged 10 commits into from
Oct 26, 2023
Merged

mask-image property added and code refactor #1396

merged 10 commits into from
Oct 26, 2023

Conversation

harshdoesdev
Copy link
Contributor

@harshdoesdev harshdoesdev commented Oct 19, 2023 •
edited
Loading

added the mask-image property in Common properties. The mask hides an element (partially or fully) by masking or clipping the image at specific points.

Example:

-- ftd.container:
background.solid: red
mask.image: https://mdn.github.io/css-examples/masking/star.svg
width.fixed.px: 300
height.fixed.px: 300

Output:
image

@amitu
Copy link
Contributor

amitu commented Oct 20, 2023

@harshdoesdev, @Heulitig lets ensure #1390 is solved with this PR.

@harshdoesdev harshdoesdev changed the title mask property added mask-image property added Oct 23, 2023
@harshdoesdev
Copy link
Contributor Author

harshdoesdev commented Oct 23, 2023 •
edited
Loading

@amitu, the mask-image property has been implemented. Please verify whether this resolves the issue at #1390.

Edit: @Heulitig has requested some minor changes, will quickly update you on this

@amitu
Copy link
Contributor

amitu commented Oct 23, 2023

@harshdoesdev show a demo that looks like this https://codepen.io/noahblon/pen/PovZva

@harshdoesdev
Copy link
Contributor Author

@Heulitig I have added all of the required mask properties, but when I am running the tests, I am getting stack-overflow errors (originating from a totally unrelated test, the mask test is working perfectly fine when ran individually by providing the path argument)

@harshdoesdev harshdoesdev changed the title mask-image property added mask-image property added and code refactor Oct 25, 2023
@Heulitig Heulitig merged commit 7a94e51 into main Oct 26, 2023
1 check passed
@Heulitig Heulitig deleted the mask-prop branch October 26, 2023 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@harshdoesdev @amitu @Heulitig